refactor: update blas/ext/base/dsumpw to follow current project conventions
#1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
Signed-off-by: utkarsh_raj <49344502+rajutkarsh07@users.noreply.github.com>
Closed
6 tasks
lib/node_modules/@stdlib/blas/ext/base/dsumpw/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsumpw/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsumpw/benchmark/benchmark.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsumpw/benchmark/benchmark.ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsumpw/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsumpw/test/test.dsumpw.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsumpw/test/test.dsumpw.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsumpw/test/test.dsumpw.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsumpw/test/test.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsumpw/test/test.ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsumpw/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
Planeshifter
requested changes
Mar 23, 2024
There was a problem hiding this comment.
Thanks for your efforts!
The manifest.json file will have to be changed per the new conventions, i.e. using 2-space indentation and containing multiple configurations for examples and benchmarks.
Most importantly, the addon.c file should be updated as part of the issue. Would you please look into this? The linked PRs in the RFC issue and recently merged PRs should give guidance for how this has to be done.
|
@Planeshifter I have made the suggested changes |
Planeshifter
requested changes
Mar 26, 2024
Planeshifter
added
Native Addons
Signed-off-by: utkarsh_raj <49344502+rajutkarsh07@users.noreply.github.com>
|
@Planeshifter Is this correct |
Signed-off-by: utkarsh_raj <49344502+rajutkarsh07@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Planeshifter
changed the title
blas/ext/base/dsumpw to follow current project conventionsblas/ext/base/dsumpw to follow current project conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1508
Description
This pull request:
blas/ext/base/dsumpwto follow current project conventions #1508Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers